Review Please - eviltoast
  • nick@campfyre.nickwebster.dev
    link
    fedilink
    arrow-up
    3
    ·
    8 months ago

    In my experience I haven’t had an issue because usually the refactorings are small. If they’re not I just hop on a call with the person who wrote the MR and ask them to walk me through it.

    In theory I’d like to have time to dedicate solely to code health, but that’s not quite the situation in basically any team I’ve been in.

    • onlinepersona@programming.dev
      link
      fedilink
      English
      arrow-up
      4
      arrow-down
      3
      ·
      8 months ago

      I haven’t had any trouble separating refactors PRs from ticket PRs. Make the ticket PR, make a refactor PR on that ticket PR, merge the ticket PR, rebase refactor PR on master, open ticket PR for review, done 🤷

      CC BY-NC-SA 4.0