I just made my first Lemmy PR - eviltoast

Let’s gooooooooo

    • rosenjcb@lemmy.worldOP
      link
      fedilink
      English
      arrow-up
      7
      arrow-down
      1
      ·
      1 year ago

      Sounds like a cool feature. I’m honestly down for doing a good chunk of lemmy-ui dev work as I’m kind of getting rusty in React with my new job being strictly backend these days.

      • (des)mosthenes@lemmy.world
        link
        fedilink
        English
        arrow-up
        3
        ·
        1 year ago

        I might look into it myself, definitely curious but i’m always cautious with open source projects when committing a decently sized PR - yea that’s a great way to keep the knives sharp

        • aaaantoine@lemmy.world
          link
          fedilink
          English
          arrow-up
          1
          ·
          1 year ago

          If the size of the PR is a concern, maybe the maintainers will allow a staged approach. Create an Issue describing the feature and indicate step by step how you would implement. Then break the work into multiple pull requests.

          If necessary, you could introduce a toggle that’s switched off by default until the feature is fully implemented.

    • XTornado@lemmy.ml
      link
      fedilink
      English
      arrow-up
      4
      ·
      1 year ago

      Yeah man… I am still waiting for that option that reddit has that hides any content you already upvoted/downvoted.