looks good to me - eviltoast
  • pscamodio@feddit.it
    24·
    18 天前

    Meanwhile in another universe one of my biggest win was to introduce this line in our PR validation pipeline.

    eslint . --max-warnings 0
    • skuzz@discuss.tchncs.de
      3·
      17 天前

      Works so well, and soothes the warning annoyance brain, and keeps warnings from eventually becoming errors.

      • pscamodio@feddit.it
        3·
        17 天前

        In a codebase with a lot of warnings is even better for me to add a disable comments for all the existing warning and then not allow any new one in.

        And then each time a part of the code needs to be touched the existing warning there should be solved too.

        • jjjalljs@ttrpg.network
          2·
          17 天前

          Several times I’ve set the max warnings to whatever the current warning count is, and then decreased that over time.